Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: UI data stubs #170

Merged
merged 14 commits into from
Dec 12, 2023
Merged

chore: UI data stubs #170

merged 14 commits into from
Dec 12, 2023

Conversation

andrii-uhryn-absa
Copy link
Collaborator

No description provided.

niall-shaw
niall-shaw reviewed Dec 1, 2023
View reviewed changes
packages/frontend/src/fixtures/stubs.ts Outdated Show resolved Hide resolved
packages/frontend/src/fixtures/stubs.ts Outdated Show resolved Hide resolved
packages/frontend/src/fixtures/stubs.ts Outdated Show resolved Hide resolved
packages/frontend/src/fixtures/stubs.ts Outdated Show resolved Hide resolved
jakubkoci
jakubkoci reviewed Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@jakubkoci jakubkoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good Andrii, just use a real data pls. Absa, Standard Bank, ... It helps to understand the system and relations.

packages/frontend/src/fixtures/stubs.ts Outdated Show resolved Hide resolved
packages/frontend/src/fixtures/stubs.ts Outdated Show resolved Hide resolved
packages/frontend/src/fixtures/stubs.ts Outdated Show resolved Hide resolved
jakubkoci
jakubkoci requested changes Dec 5, 2023
View reviewed changes
packages/frontend/src/fixtures/stubs.ts Show resolved Hide resolved
packages/frontend/src/fixtures/stubs.ts Outdated Show resolved Hide resolved
jakubkoci
jakubkoci requested changes Dec 6, 2023
View reviewed changes
packages/frontend/src/fixtures/stubs.ts Outdated Show resolved Hide resolved
packages/frontend/src/fixtures/stubs.ts Outdated Show resolved Hide resolved
packages/frontend/src/fixtures/stubs.ts Outdated Show resolved Hide resolved
jakubkoci
jakubkoci reviewed Dec 12, 2023
View reviewed changes
packages/frontend/src/fixtures/stubs.ts Outdated Show resolved Hide resolved
packages/frontend/src/fixtures/stubs.ts Outdated Show resolved Hide resolved
@jakubkoci jakubkoci merged commit ba6e5f7 into main Dec 12, 2023
5 checks passed
@jakubkoci jakubkoci deleted the feat/stubs branch December 12, 2023 15:00
@jakubkoci jakubkoci changed the title feat: UI data stubs chore: UI data stubs Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubkoci jakubkoci jakubkoci approved these changes

@niall-shaw niall-shaw Awaiting requested review from niall-shaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrii-uhryn-absa @jakubkoci @niall-shaw